[PATCH] D69578: [AIX] Add support for lowering int, float and double formal arguments.

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 07:15:59 PST 2019


jasonliu added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6889
+
+  // Set the size that is at least reserved in caller of this function.  Tail
+  // call optimized function's reserved stack space needs to be aligned so
----------------
nit: Extra space before "Tail".


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6892
+  // that taking the difference between two stack areas will result in an
+  // aligned stack. reserved for caller
+  MinReservedArea =
----------------
nit: Since we have "Set the size that is at least reserved in caller of this function" in the beginning of this paragraph, "reserved for caller" at the end could be removed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69578/new/

https://reviews.llvm.org/D69578





More information about the llvm-commits mailing list