[PATCH] D70296: [ARM,MVE] Add reversed isel patterns for MVE `vcmp qN,rN`

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 05:55:24 PST 2019


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Oh OK. I was assuming this would be done in DAG2DAG, where it would attempt to canonicalise vdups or 0's to the right of a vcmp. And then do any folding or whathaveyou to try and come up with a sequence of instructions that would end up being selected nicely (turning Ors into Ands and such).

It can be done in tablegen pattern though, that sounds OK. We might eventually want to put it in DAG2DAG as well, as it will likely be doing similar things anyway.

LGTM. Looks like a nice improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70296/new/

https://reviews.llvm.org/D70296





More information about the llvm-commits mailing list