[PATCH] D70264: [yaml2obj][test] Move tests to binary format specific subdirectories

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Mostly looks fine to me.



================
Comment at: llvm/test/tools/yaml2obj/ELF/symbol-index-invalid.yaml:1
-# This test insures that the user cannot have both an Index and a Section field.
+## Check that "Index" and "Section" cannot be used together.
+
----------------
Maybe add "in a symbol".


================
Comment at: llvm/test/tools/yaml2obj/ELF/verdef-section.yaml:1
+## Check we are able to handle the SHT_GNU_verdef sections.
+
----------------
Delete "the".


================
Comment at: llvm/test/tools/yaml2obj/ELF/verneed-section.yaml:1
+## Check we are able to handle the SHT_GNU_verneed sections.
+
----------------
Delete "the".


================
Comment at: llvm/test/tools/yaml2obj/empty-symbols.yaml:10
-  Machine:         EM_X86_64
-Symbols:
----------------
I might be misreading the intent of the comment, but I think there's value in testing:

```
  Symbols:
```
distinctly from
```
  Symbols: []
```

In other words, can yaml2obj handle it with/without the `[]`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70264/new/

https://reviews.llvm.org/D70264