[PATCH] D70121: [WIP][DebugInfo][LDV] Attempt to teach LDV how to handle fragments

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando marked 2 inline comments as done and an inline comment as not done.
Orlando added a comment.

+ Added reviewers



================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:322
+/// A user value group contains the set of debug info user variables
+/// which refer to the same DILocalVariable in the same inlining scope.
+class UserValueGroup {
----------------
Orlando wrote:
> aprantl wrote:
> > I don't know if this helps, but in other places we conceptually treat `std::pair<DILocalVariable *, FragmentInfo>` as unique "variables" and the remainder expression as part of a "location".
> Yes that makes sense, I can probably improve the class name and comment here.
These terms feel overloaded but much more descriptive. How do you feel about this kind of thing:

UserValue is now responsible for all DBG_VALUEs which refer to an exact _fragment_.

    UserValue -> Fragment

UserValueGroup groups UserValues (Fragments) that refer to the same _variable_

    UserValueGroup -> Variable

Maybe a suitable prefix would help too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70121/new/

https://reviews.llvm.org/D70121