[PATCH] D69730: [compiler-rt][builtins][PowerPC] Add __fixtfti builtin on PowerPC

Kamau Bridgeman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 14 12:16:14 PST 2019


kamaub added a comment.

This LGTM, please unify the comment styles.



================
Comment at: compiler-rt/test/builtins/Unit/ppc/fixtfti_test.c:9
+
+/* The long double representation, with the high and low portions of
+ * the long double, and the corresponding bit patterns of each double. */
----------------
Same here, mismatched comment styles.


================
Comment at: compiler-rt/test/builtins/Unit/ppc/fixtfti_test.h:1
+/*
+* Test case inputs for: __int128_t __fixtfti (long double)
----------------
Very minor nit: could you change this comment style to match the rest of the file (`/**/` vs `//`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69730/new/

https://reviews.llvm.org/D69730





More information about the llvm-commits mailing list