[PATCH] D69723: [RISCV] Fix wrong CFI directives

[Luís Marques via Phabricator via llvm-commits]

luismarques marked 2 inline comments as done.
luismarques added inline comments.


================
Comment at: llvm/test/DebugInfo/RISCV/relax-debug-frame.ll:15
 ; RELAX-NOT: {{[}]}}
-; RELAX: 0x25 R_RISCV_SET6
-; RELAX: 0x25 R_RISCV_SUB6
+; RELAX: 0x39 R_RISCV_SET6
+; RELAX: 0x39 R_RISCV_SUB6
----------------
shiva0217 wrote:
> I think it might a reasonable changing. According to https://github.com/riscv/riscv-binutils-gdb/blob/riscv-binutils-2.29/gas/config/tc-riscv.c#L1940, R_RISCV_SET6 and R_RISCV_SUB6 are relocation types for DW_CFA_advance_loc. It seems that the check line didn't show all the relocation types of the object, the number of the reduction of R_RISCV_SET6 and R_RISCV_SUB6 reflect the reduction of the CFI directives.
Thanks, that's exactly the kind of reassuring feedback I was looking for! :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69723/new/

https://reviews.llvm.org/D69723