[PATCH] D70224: [WinEH] Fix the wrong alignment orientation during calculating EH frame.

Thu Nov 14 18:08:01 PST 2019

pengfei marked an inline comment as done.
pengfei added a comment.

Hi @rnk, I guess we need to merge it to 9.0 branch, right? I haven't  did such before, do I need wait for someone approval? Is there someone responsible for committing, or I can do it myself?

================
Comment at: llvm/test/CodeGen/X86/win64-funclet-savexmm.ll:92
-; CHECK: .seh_savexmm %xmm7, 64
-; CHECK: vmovaps %xmm6, 80(%rsp)
-; CHECK: .seh_savexmm %xmm6, 80
----------------
rnk wrote:
> So, this was wrong, it was storing to memory at RSP+[80-96], which would overwrite `pushq %rbx` from above. Yikes.
Sorry for the mistake.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70224/new/

https://reviews.llvm.org/D70224