[PATCH] D70251: [yaml2obj][COFF] Add support for extended relocation tables

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/coff-xrelocs.yaml:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj --sections --relocations %t | FileCheck %s --check-prefix=CHECK-OBJ
----------------
sdmitriev wrote:
> MaskRay wrote:
> > A file-level comment about the purpose of the test. The mapping `xrelocs -> extended relocation table` is not very obvious.
> > 
> > Maybe it is time to place binary format specific tests in their own directories, and for this one, `COFF/`?
> > A file-level comment about the purpose of the test. The mapping xrelocs -> extended relocation table is not very obvious.
> 
> Done.
> 
> > Maybe it is time to place binary format specific tests in their own directories, and for this one, COFF/?
> 
> This should probably be done in separate commit.
I have created https://reviews.llvm.org/D70264 to reorganize the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70251/new/

https://reviews.llvm.org/D70251