[PATCH] D70251: [yaml2obj][COFF] Add support for extended relocation tables

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/ObjectYAML/COFFEmitter.cpp:515
+         << binary_le<uint32_t>(/*SymbolTableIndex=*/0)
+         << binary_le<uint16_t>(/*Type*/ 0);
     for (const COFFYAML::Relocation &R : S.Relocations) {
----------------
Be consistent: `/*Type=*/`


================
Comment at: llvm/test/tools/yaml2obj/coff-xrelocs.yaml:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj --sections --relocations %t | FileCheck %s --check-prefix=CHECK-OBJ
----------------
A file-level comment about the purpose of the test. The mapping `xrelocs -> extended relocation table` is not very obvious.

Maybe it is time to place binary format specific tests in their own directories, and for this one, `COFF/`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70251/new/

https://reviews.llvm.org/D70251