[PATCH] D70161: [cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 14 10:25:00 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rGcfca818ef7b8: [cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows (authored by tstellar).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70161/new/

https://reviews.llvm.org/D70161

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -574,6 +574,9 @@
   # Set this variable to OFF here so it can't be set with a command-line
   # argument.
   set (LLVM_LINK_LLVM_DYLIB OFF)
+  if (BUILD_SHARED_LIBS)
+    message(FATAL_ERROR "BUILD_SHARED_LIBS options is not supported on Windows.")
+  endif()
 else()
   option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF)
   option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70161.229348.patch
Type: text/x-patch
Size: 588 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191114/5ad10103/attachment.bin>


More information about the llvm-commits mailing list