[PATCH] D70224: [WinEH] Fix the wrong alignment orientation during calculating EH frame.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 14 09:48:01 PST 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/test/CodeGen/X86/win64-funclet-savexmm.ll:92
-; CHECK: .seh_savexmm %xmm7, 64
-; CHECK: vmovaps %xmm6, 80(%rsp)
-; CHECK: .seh_savexmm %xmm6, 80
----------------
So, this was wrong, it was storing to memory at RSP+[80-96], which would overwrite `pushq %rbx` from above. Yikes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70224/new/

https://reviews.llvm.org/D70224





More information about the llvm-commits mailing list