[PATCH] D69997: [llvm-objdump] Print relocation addends in hexadecimal

Thu Nov 14 02:22:28 PST 2019

grimar added a comment.

A few minor requests from me.

================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs.test:88
+  Flags: [SHF_EXECINSTR,SHF_ALLOC]
+
+- Name: .rela.text
----------------
Please remove this empty line and the one below (we don't have such lines in our another tests and while I think I understand why you added them, it is still inconsistent, what is probably much more important. Another argument is that obj2yaml does not do that too).

================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs.test:100
+      Type:   R_X86_64_64
+      Addend: 9223372036854775807
+    - Offset: 0x2
----------------
Could you please comment this and above (or just all the) Addends? They are probably not obvious for a new readers.

================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs.test:118
+    Value:   0x0
+    Size:    0
+    Binding: STB_GLOBAL
----------------
Do you need 'Size`? I haven't check but I suspect that you dont need 'Size' and 'Binding', I am not sure though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69997/new/

https://reviews.llvm.org/D69997