[PATCH] D70170: [AMDGPU][MC][GFX10] Enabled v_movrel*[sdwa|dpp|dpp8] opcodes

Wed Nov 13 11:59:48 PST 2019

rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM with a nit: please remove the comment.

================
Comment at: llvm/lib/Target/AMDGPU/VOP1Instructions.td:282

-  let HasExt = 0;
-  let HasExtDPP = 0;
-  let HasExtSDWA = 0;
-  let HasExtSDWA9 = 0;
+  // sdwa/dpp/dpp8 are defined with dst - for use in assembler only.
+
----------------
I do not think you can really limit it to asm only. If you have defined it then eventually compiler may combine it. I'd suggest to remove the comment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70170/new/

https://reviews.llvm.org/D70170