[PATCH] D69830: [LoopPred/WC] Use a dominating widenable condition to remove analyze loop exits

Evgeniy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 13 04:34:14 PST 2019


ebrevnov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:1108
+    BasicBlock *ExitBB = BI->getSuccessor(ExitIfTrue ? 0 : 1);
+    if (!ExitBB->getTerminatingDeoptimizeCall())
+      // Profitability: indicator of rarely/never taken exit
----------------
Would it be better to check profitability in a more general way using BPI or similar?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69830/new/

https://reviews.llvm.org/D69830





More information about the llvm-commits mailing list