[PATCH] D70009: [ARM][ReachingDefAnalysis] Use RDA for loloops

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:138
   MF = &mf;
+  MF->getProperties().set(MachineFunctionProperties::Property::TracksLiveness);
   TRI = MF->getSubtarget().getRegisterInfo();
----------------
arsenm wrote:
> samparker wrote:
> > dmgreen wrote:
> > > Can you explain this? Is it valid to just set this property?
> > This pass doesn't change the code so this should be fine. But now I'm thinking that this pass also should require that liveness information is correct on entry.
> Yes, this should be setting this in getRequiredProperties
I thought this was a property, like IsSSA. I'm not very sure either way, but it might not be valid to set that the property holds without checking that it does.

Do you know which pass is causing the property to be removed? Can we fix that to keep it valid?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70009/new/

https://reviews.llvm.org/D70009