[PATCH] D68857: [X86] Add strict fp support for operations of X87 instructions

Tue Nov 12 21:05:50 PST 2019

pengfei added a comment.

In D68857#1743302 <https://reviews.llvm.org/D68857#1743302>, @craig.topper wrote:

> I think we need to re-evaluate our testing strategy here. These tests pass on trunk without any of the other changes.
>
> I was going to suggest adding -stop-after=finalize-isel so we could check the fpexcept bit, but the mutating code preserves the fpexcept bit from the strict fp node we mutated. So I'm not sure how we can tell that this patch works correctly.

How about using option "-debug-only=isel" and then checking the STRICT* node?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68857/new/

https://reviews.llvm.org/D68857