[PATCH] D70105: [lit] Better/earlier errors for empty runs

[Joel E. Denny via Phabricator via llvm-commits]

jdenny marked an inline comment as done.
jdenny added inline comments.


================
Comment at: llvm/utils/lit/lit/run.py:48
         """
-        if not self.tests:
-            return 0.0
----------------
yln wrote:
> jdenny wrote:
> > Would it be wortwhile to turn this guard into an assert rather than just removing it?
> This function works for zero tests (although it then creates a process pool for no reason). It's just that you can't create a process pool with zero workers and we use `min(test_count, cpu_cores)` to determine the number of workers.  We have an assert for this above.
Sounds reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70105/new/

https://reviews.llvm.org/D70105