[PATCH] D70082: [AArch64] Extend storeRegToStackSlot to spill SVE registers.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 12 05:07:47 PST 2019


sdesmalen marked an inline comment as done.
sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:2960
   bool Offset = true;
   switch (TRI->getSpillSize(*RC)) {
   case 1:
----------------
efriedma wrote:
> I'd prefer to refactor the code so it doesn't depend on what getSpillSize returns for SVE types.
The SVE case is actually outside the switch statement and is therefore independent of what getSpillSize returns. The switch statement seems to be there purely for having a quicker look-up as opposed to having a long `if-elseif-elseif-[..]-elseif` chain. Do you want me to change that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70082/new/

https://reviews.llvm.org/D70082





More information about the llvm-commits mailing list