[PATCH] D70107: [VFABI] TargetLibraryInfo mappings in IR.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/InjectTLIMappings.cpp:66
+                                  const StringRef VFName) {
+  assert(CI && "Invalid CallInst.");
+  Module *M = CI->getParent()->getParent()->getParent();
----------------
When you think the patch is ready to be reviewed, can you address the comments that I added in D69976 before you removed it?


================
Comment at: llvm/test/Transforms/Util/add-TLI-mappings.ll:17
+for.body:
+  %iv = phi i64 [ 0, %entry ], [ %iv.next, %for.body ]
+  %tmp = trunc i64 %iv to i32
----------------
I don't think you need to add a loop here to prove the IR contains the vectorized versions of the IR, a call to `@sin` should be sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70107/new/

https://reviews.llvm.org/D70107