[PATCH] D70038: [AMDGPU] add support for hostcall buffer pointer as hidden kernel argument

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:859-860
       emitKernelArg(DL, Int8PtrTy, "hidden_printf_buffer", Offset, Args);
+    else if (Func.getParent()->getFunction("__ockl_hostcall_internal"))
+      emitKernelArg(DL, Int8PtrTy, "hidden_hostcall_buffer", Offset, Args);
     else
----------------
Is this metadata really necessary if the runtime can just check if the symbol is used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70038/new/

https://reviews.llvm.org/D70038