[PATCH] D67283: [GCOV] Skip artificial functions from being emitted

Mon Nov 11 16:37:00 PST 2019

dblaikie added a comment.

Trying to piece together the history here

https://bugs.llvm.org/show_bug.cgi?id=43012 - an assertion failure when using debug info (the classic "inlinable function call in a function with debug info must have a !dbg location").

https://reviews.llvm.org/D66328 to fix PR43012, has two associated commits 
r369458: [DebugInfo] Add debug location to dynamic atexit destructor
 -> reverted in r69633
r371080: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

I can't reproduce the original crash right now based on the repro steps in PR43012, but perhaps I'm doing something incorrect?
If not, then perhaps r371080 fixed the original bug? So there's some other bugs that are being fixed by r369458/this patch being reviewed that unblocks that change?

Does this hit the same GCOV issue due to line zeros? But the existing fix to line zeros should hold here - but GCOV trips over a function defined at line zero? Or a function without any non-zero lines?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67283/new/

https://reviews.llvm.org/D67283