[PATCH] D69411: [MC] Enhance parsing of .if conditions

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 10:50:25 PST 2019


jcai19 marked 2 inline comments as done.
jcai19 added inline comments.


================
Comment at: llvm/lib/MC/MCExpr.cpp:593
+          FragA == FragB) {
+        Addend += (SA.getOffset() - SB.getOffset());
+        FinalizeFolding();
----------------
peter.smith wrote:
> This might not be needed with D70062 as the !SA.isUnset() and !SB.isUnset() on line 568 will both evaluate true after it.
Thanks for the clarification. I have adjusted my code accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69411/new/

https://reviews.llvm.org/D69411





More information about the llvm-commits mailing list