[PATCH] D70075: [InstCombine] Skip scalable vectors in combineLoadToOperationType

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 06:41:56 PST 2019


sdesmalen added a comment.

Thanks for this fix @rovka!



================
Comment at: llvm/test/Transforms/InstCombine/load.ll:240
 
+define void @test16-vect(i8* %x, i8* %a, i8* %b, i8* %c) {
+; CHECK-LABEL: @test16-vect(
----------------
Is this just adding a missing test-case for existing code, or are you trying to test something else?


================
Comment at: llvm/test/Transforms/InstCombine/load.ll:340
+
+; Make sure we don't canonicalize accesses to scalable vectors.
+define void @test20(<vscale x 4 x i8>* %addr) {
----------------
Does this need a CHECK line to test for non-assert builds?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70075/new/

https://reviews.llvm.org/D70075





More information about the llvm-commits mailing list