[PATCH] D69601: [Power9] Implement the vector extend sign instruction pattern match

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 10 18:36:21 PST 2019


steven.zhang marked an inline comment as done.
steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:4305
 
+  let Predicates = [HasP9Altivec] in {
+    def : Pat<(v4i32 (sext_inreg v4i32:$VRB, v4i8)), (v4i32 (VEXTSB2W $VRB))>;
----------------
nemanjai wrote:
> I don't really see a reason to put this into PPCInstrVSX.td. Seems like PPCInstrAltivec.td would be a more appropriate place for it.
Hmm, make sense. It is interesting that, we put the match pattern from build_vector to VEXTSB2D here too ...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69601/new/

https://reviews.llvm.org/D69601





More information about the llvm-commits mailing list