[PATCH] D70011: lld patch for Linker Script UTF-8 BOM encoding capability

Fri Nov 8 12:25:31 PST 2019

MaskRay added a comment.

In D70011#1739193 <https://reviews.llvm.org/D70011#1739193>, @cameron314 wrote:

> I disagree, `ld` emitting invalid character warnings is simply a good indication that it was never tested with such an input :-)

... I actually think this is a good indication that your tests have never been verified. If you append `--fatal-warnings` (like the compiler driver option `-Werror`), ld.bfd will return 1.

> If the community thinks this bug isn't important enough to warrant the two-line fix, then so be it, I won't push the matter. No hard feelings.
>  This was merely an attempt to fix another instance of a common Windows-incompatibility bug that we happened to come across with a real-world linker script.

>From your arguments I never see the reasoning that this should be supported ;-)

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70011/new/

https://reviews.llvm.org/D70011