[PATCH] D69977: [InstCombine] avoid crash from deleting an instruction that still has uses (PR43723)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 12:06:52 PST 2019


spatel added a comment.

In D69977#1739212 <https://reviews.llvm.org/D69977#1739212>, @efriedma wrote:

> How confident are we that there aren't other uses of the return value of llvm.invariant.start?


Personally, I'm not confident because I haven't looked at these before:
http://llvm.org/docs/LangRef.html#memory-use-markers

But based on my initial reading, only invariant.end is meant to use invariant.start? We could assert that the 'end' has a corresponding 'start' and that it is the only user?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69977/new/

https://reviews.llvm.org/D69977





More information about the llvm-commits mailing list