[PATCH] D70024: [compiler-rt] Disable fuzzer large.test when LLVM_ENABLE_EXPENSIVE_CHECKS=ON.

[Volodymyr Sapsai via Phabricator via llvm-commits]

vsapsai created this revision.
vsapsai added reviewers: morehouse, kcc, delcypher.
Herald added subscribers: Sanitizers, ributzka, dexonsmith, jkorous, dberris.
Herald added projects: Sanitizers, LLVM.

This test is timing out on Green Dragon http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/
and looks like it's not executed on other bots with expensive checks
enabled
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win

I don't know if it is the right approach or if it defeats the purpose of
the test. So I want to discuss if it is a reasonable fix and then I can
polish the code. So far I haven't tested it but it should convey my
intention.

rdar://problem/56377397


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70024

Files:
  compiler-rt/test/fuzzer/large.test
  compiler-rt/test/lit.common.cfg.py
  compiler-rt/test/lit.common.configured.in


Index: compiler-rt/test/lit.common.configured.in
===================================================================
--- compiler-rt/test/lit.common.configured.in
+++ compiler-rt/test/lit.common.configured.in
@@ -42,6 +42,7 @@
 set_default("android_files_to_push", [])
 set_default("have_rpc_xdr_h", @HAVE_RPC_XDR_H@)
 set_default("gwp_asan", @COMPILER_RT_HAS_GWP_ASAN_PYBOOL@)
+set_default("expensive_checks", @LLVM_ENABLE_EXPENSIVE_CHECKS_PYBOOL@)
 config.available_features.add('target-is-%s' % config.target_arch)
 
 if config.enable_per_target_runtime_dir:
Index: compiler-rt/test/lit.common.cfg.py
===================================================================
--- compiler-rt/test/lit.common.cfg.py
+++ compiler-rt/test/lit.common.cfg.py
@@ -477,6 +477,9 @@
 else:
   config.available_features.add("shadow-scale-3")
 
+if config.expensive_checks:
+  config.available_features.add("expensive_checks")
+
 # Propagate the LLD/LTO into the clang config option, so nothing else is needed.
 run_wrapper = []
 target_cflags = [getattr(config, 'target_cflags', None)]
Index: compiler-rt/test/fuzzer/large.test
===================================================================
--- compiler-rt/test/fuzzer/large.test
+++ compiler-rt/test/fuzzer/large.test
@@ -1,3 +1,5 @@
+UNSUPPORTED: expensive_checks
+
 RUN: %cpp_compiler %S/LargeTest.cpp -o %t-LargeTest
 RUN: %run %t-LargeTest -runs=10000
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70024.228507.patch
Type: text/x-patch
Size: 1400 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191108/b2a93da6/attachment.bin>