[PATCH] D70014: ThinLTO : Import always_inline functions irrespective of the threshold

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 11:21:30 PST 2019


tejohnson added a comment.

Thanks for working on this! One suggestion for test cleanup below.



================
Comment at: llvm/test/ThinLTO/X86/funcimport_alwaysinline.ll:29
+entry:
+  call void @bar()
+  call void @bar()
----------------
I don't think you need all these calls to @bar (or any, or the def of @bar). I believe this was from another test that was testing the import-instr-limit. Since you have 0 you don't need anything here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70014/new/

https://reviews.llvm.org/D70014





More information about the llvm-commits mailing list