[PATCH] D70011: lld patch for Linker Script UTF-8 BOM encoding capability

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 10:26:41 PST 2019


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

This doesn't seem very necessary.  GNU ld rejects BOM as well. I think you can achieve cross compilability by simply removing BOM.

  % xxd a.x
  00000000: efbb bf45 4e54 5259 285f 6c61 6265 6c29  ...ENTRY(_label)
  00000010: 0a
  % ld.bfd a.o -T a.x -o a
  ld.bfd:a.x:1: ignoring invalid character `\357' in expression
  ld.bfd:a.x:1: ignoring invalid character `\273' in expression
  ld.bfd:a.x:1: ignoring invalid character `\277' in expression


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70011/new/

https://reviews.llvm.org/D70011





More information about the llvm-commits mailing list