[PATCH] D65121: [FileCheck] Make FILECHECK_OPTS useful for its test suite

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 228468.
jdenny edited the summary of this revision.
jdenny added a comment.

Now that D65156 <https://reviews.llvm.org/D65156> and its many dependencies seem to have survived the bots, I'm finally returning to this patch.

This update rebases onto a recent master and adds `%ProtectFileCheckOutput` to a few new `RUN` lines that have since appeared in FileCheck's test suite.

As discussed at D65121#1637145 <https://reviews.llvm.org/D65121#1637145>, we need to decide whether to eliminate `env -u` uses in this patch or to switch FileCheck's test suite to lit's internal shell.  Either looks easy to do, but I vote for the latter as it seems better for portability in the long term.  It appears to just require this in `llvm/test/FileCheck/lit.local.cfg` (`llvm/utils/lit/tests/lit.cfg` already has this):

  import lit
  config.test_format = lit.formats.ShTest(execute_external=False)

What do people think?  I'll probably make that a separate review if there are no immediate objections to the idea.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65121/new/

https://reviews.llvm.org/D65121

Files:
  llvm/docs/TestingGuide.rst
  llvm/test/FileCheck/check-count.txt
  llvm/test/FileCheck/check-empty-tag.txt
  llvm/test/FileCheck/check-empty.txt
  llvm/test/FileCheck/check-ignore-case.txt
  llvm/test/FileCheck/check-label-dag.txt
  llvm/test/FileCheck/check-label.txt
  llvm/test/FileCheck/check-multiple-prefixes-nomatch-2.txt
  llvm/test/FileCheck/check-multiple-prefixes-nomatch.txt
  llvm/test/FileCheck/check-not-diaginfo.txt
  llvm/test/FileCheck/check-prefixes.txt
  llvm/test/FileCheck/dump-input-annotations.txt
  llvm/test/FileCheck/dump-input-enable.txt
  llvm/test/FileCheck/envvar-opts.txt
  llvm/test/FileCheck/implicit-check-not.txt
  llvm/test/FileCheck/line-count.txt
  llvm/test/FileCheck/lit.local.cfg
  llvm/test/FileCheck/match-full-lines.txt
  llvm/test/FileCheck/multiple-missing-prefixes.txt
  llvm/test/FileCheck/no-check-file.txt
  llvm/test/FileCheck/no-multi-suffixes.txt
  llvm/test/FileCheck/numeric-defines-diagnostics.txt
  llvm/test/FileCheck/numeric-defines.txt
  llvm/test/FileCheck/numeric-expression.txt
  llvm/test/FileCheck/opt-color.txt
  llvm/test/FileCheck/string-defines-diagnostics.txt
  llvm/test/FileCheck/string-defines.txt
  llvm/test/FileCheck/validate-check-prefix.txt
  llvm/test/FileCheck/var-scope.txt
  llvm/test/FileCheck/verbose.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65121.228468.patch
Type: text/x-patch
Size: 55434 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191108/d6fd704b/attachment.bin>