[PATCH] D70010: [OpenMP][Offloading] Replaced default stream with an actual per-device unblocking stream in NVPTX implementation

Shilei Tian via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 08:26:19 PST 2019


tianshilei1992 marked an inline comment as done.
tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:260
+    // Destroy streams
+    for (auto &stream : Streams)
+      if (stream) {
----------------
ABataev wrote:
> 1. Use real type instead of `auto`
> 2. Variables must start with the upper case letter.
Sure but just to keep align with existing code. Do I need to update existing code as well?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70010/new/

https://reviews.llvm.org/D70010





More information about the llvm-commits mailing list