[PATCH] D69955: [DebugInfo] Add helper for finding entry value candidates [NFC]

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

This looks very good to me! Thanks!



================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:95
+/// we do not support it at the moment.
+static bool isRegOtherThanSPAndFP(const MachineOperand &Op,
+                                  const MachineInstr &MI,
----------------
dstenb wrote:
> Taken from D68209.
This is OK. I will rebase the diff on top of this one.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1355
+    if (isEntryValueCandidate(MI))
+      if (!DebugEntryVals.count(MI.getDebugVariable()))
+        DebugEntryVals[MI.getDebugVariable()] = &MI;
----------------
One `if` with the `&&`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69955/new/

https://reviews.llvm.org/D69955