[PATCH] D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:10064
+                                                 SDNodeXForm<imm, [{
+  return CurDAG->getTargetConstant((N->getSExtValue() / 90), SDLoc(N), MVT::i64);
+}]>> {
----------------
should the target constant not be MVT::i32 here?


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:10071
+                                                 SDNodeXForm<imm, [{
+  return CurDAG->getTargetConstant(((N->getSExtValue() - 90) / 180), SDLoc(N), MVT::i64);
+}]>> {
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69707/new/

https://reviews.llvm.org/D69707