[PATCH] D69989: Assume ieee behavior without denormal-fp-math attribute

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 7 23:13:23 PST 2019


arsenm created this revision.
arsenm added reviewers: andrew.w.kaylor, cameron.mcinally, spatel.
Herald added subscribers: hiraditya, wdng.
Herald added a project: LLVM.
arsenm added a parent revision: D69982: PPC: Prepare tests for switch of default denormal-fp-math.

https://reviews.llvm.org/D69989

Files:
  llvm/lib/CodeGen/MachineFunction.cpp


Index: llvm/lib/CodeGen/MachineFunction.cpp
===================================================================
--- llvm/lib/CodeGen/MachineFunction.cpp
+++ llvm/lib/CodeGen/MachineFunction.cpp
@@ -284,15 +284,7 @@
   // TODO: Should probably avoid the connection to the IR and store directly
   // in the MachineFunction.
   Attribute Attr = F.getFnAttribute("denormal-fp-math");
-
-  // FIXME: This should assume IEEE behavior on an unspecified
-  // attribute. However, the one current user incorrectly assumes a non-IEEE
-  // target by default.
-  StringRef Val = Attr.getValueAsString();
-  if (Val.empty())
-    return DenormalMode::getInvalid();
-
-  return parseDenormalFPAttribute(Val);
+  return parseDenormalFPAttribute(Attr.getValueAsString());
 }
 
 /// Should we be emitting segmented stack stuff for the function


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69989.228370.patch
Type: text/x-patch
Size: 829 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191108/bffef1d5/attachment.bin>


More information about the llvm-commits mailing list