[PATCH] D69985: Keep symbols passed by -init and -fini

[Rui Ueyama via Phabricator via llvm-commits]

ruiu created this revision.
ruiu added reviewers: MaskRay, grimar.
Herald added subscribers: dexonsmith, steven_wu, hiraditya, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

Previously, symbols passed by -init and -fini look as if they are
not referenced by anyone, and the LTO might eliminate them.
This patch fixes the issue.

Fixes a bug reported in https://bugs.llvm.org/show_bug.cgi?id=43927


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69985

Files:
  lld/ELF/Driver.cpp
  lld/test/ELF/lto/init-fini.ll


Index: lld/test/ELF/lto/init-fini.ll
===================================================================
--- /dev/null
+++ lld/test/ELF/lto/init-fini.ll
@@ -0,0 +1,27 @@
+; REQUIRES: x86
+; RUN: llvm-as %s -o %t.o
+
+;; Verify that symbols given by -init and -fini are preserved.
+
+; RUN: ld.lld -o %t.exe %t.o
+; RUN: llvm-objdump -t %t.exe | FileCheck -check-prefix=TEST1 %s
+
+; TEST1-NOT: foo
+; TEST1-NOT: bar
+
+; RUN: ld.lld -o %t.exe -init=foo -fini=bar %t.o
+; RUN: llvm-objdump -t %t.exe | FileCheck -check-prefix=TEST2 %s
+
+; TEST2: foo
+; TEST2: bar
+
+target triple = "x86_64-unknown-linux-gnu"
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
+define void @foo() {
+  ret void
+}
+
+define void @bar() {
+  ret void
+}
Index: lld/ELF/Driver.cpp
===================================================================
--- lld/ELF/Driver.cpp
+++ lld/ELF/Driver.cpp
@@ -1782,6 +1782,12 @@
   for (StringRef pat : args::getStrings(args, OPT_undefined_glob))
     handleUndefinedGlob(pat);
 
+  // Mark -init and -fini symbols so that the LTO doesn't eliminate them.
+  if (Symbol *sym = symtab->find(config->init))
+    sym->isUsedInRegularObj = true;
+  if (Symbol *sym = symtab->find(config->fini))
+    sym->isUsedInRegularObj = true;
+
   // If any of our inputs are bitcode files, the LTO code generator may create
   // references to certain library functions that might not be explicit in the
   // bitcode file's symbol table. If any of those library functions are defined


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69985.228365.patch
Type: text/x-patch
Size: 1536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191108/6fc431e2/attachment.bin>