[PATCH] D67572: [SVFS] The Search Vector Function System.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:198
+  explicit SearchVFSystem(CallInst *CI)
+      : CI(CI), M(CI->getParent()->getParent()->getParent()) {}
+  /// \defgroup TLI legacy interface
----------------
Arguably, you could just call `getVFMappings` and cache the result. Whoever created a SearchVFSystem will need the values eventually and this way the `isFucntionVectorizable` call is free.

`CI->getModule()`

The explicit and delete seems a lot of overhead, make the member a `CallInst &CI` and you should not  need any of it.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:240
+};
+
 template <typename T> class ArrayRef;
----------------
Typos in the above TODO.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2435-2436
+
   return false;
 }
 
----------------
Leftover?


================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:22
 using namespace llvm;
 
 static cl::opt<TargetLibraryInfoImpl::VectorLibrary> ClVectorLibrary(
----------------
Leftover?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67572/new/

https://reviews.llvm.org/D67572