[PATCH] D69552: Move floating point related entities to namespace level

Thu Nov 7 18:00:04 PST 2019

arsenm added a comment.

In D69552#1736486 <https://reviews.llvm.org/D69552#1736486>, @sepavloff wrote:

> In D69552#1735614 <https://reviews.llvm.org/D69552#1735614>, @arsenm wrote:
>
> > I think these enums should go into the same header as added in D69598 <https://reviews.llvm.org/D69598>
>
>
> It is definitely a good idea. But I would propose to move enums from `llvm/ADT/FloatingPointMode.h` in D69598 <https://reviews.llvm.org/D69598> to the file `FPEnv.h` from this patch. The directory `ADT` is for //Advanced Data Types// and contains mostly general purpose classes. On the other hand enum `DenormalMode` in that file implements representation of floating point environment. Now it is used in CodeGen, but exposing it to users seems to be natural step, as now we do not have a way to control handling denormals.
>
> We need to agree upon file name. Initially the file was `FloatingPoint.h`, then it was renamed to `FPEnv.h` to be more specific. What is your opinion about the name?
>  Also we could agree whether to use namespaces or strict enums.

ADT is poorly named and has other things along the lines of generally useful enums. I don't really care whether this goes in IR or ADT or Support

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69552/new/

https://reviews.llvm.org/D69552