[PATCH] D69684: [debuginfo-tests] Don't look for Python 3 if we already have it

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 7 14:55:00 PST 2019


JDevlieghere added a comment.

In D69684#1737796 <https://reviews.llvm.org/D69684#1737796>, @rnk wrote:

> Would it be OK if we removed all the logic to redo the python search here, and replace it with a simple version check? So far as I know, most of the rest of LLVM is Python 3 ready, so even if you use python 2 on PATH, there's no reason not to tell cmake to use Python 3.


Very strong +1. Getting Python right (at least in CMake < 3.12) is pretty tricky as we've seen many times in LLDB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69684/new/

https://reviews.llvm.org/D69684





More information about the llvm-commits mailing list