[PATCH] D69918: [CR][WIP] Add `subWithNoWrap()` method

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 12:50:02 PST 2019


nikic added a comment.

@lebedev.ri I suspect this is due to the intersection with the raw `add()` range. Maybe it happens that the intersection between `add()` and `[MAX, MAX]` is always empty in the case where the overflow check triggers? Can you try removing that intersection and see what happens?

If that's the case, I'm not sure whether or not we should rely on that, it seems rather subtle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69918/new/

https://reviews.llvm.org/D69918





More information about the llvm-commits mailing list