[PATCH] D69722: [Utils] Reuse argument variable names in the body

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 12:13:59 PST 2019


jdoerfert added a comment.

In D69722#1733607 <https://reviews.llvm.org/D69722#1733607>, @lebedev.ri wrote:

> Can you show the effect by regenerating some test?


Take line 8 here https://reviews.llvm.org/D68766#change-4geuqNmmUCZL

  `; ARGPROMOTION-NEXT:    ret i32 [[X_VAL]]`

It uses [[X_VAL]] which is an argument of the function.
Without this check line would look like this:

  `; ARGPROMOTION-NEXT:    ret i32 [[X:.%*]]`

which has no relationship to the argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69722/new/

https://reviews.llvm.org/D69722





More information about the llvm-commits mailing list