[PATCH] D69562: Mapping of FP operations to constrained intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 10:46:01 PST 2019


arsenm added inline comments.


================
Comment at: llvm/lib/IR/FloatingPoint.cpp:172
+      default:
+        break;
+      }
----------------
arsenm wrote:
> I think this should assert or something on unhandled target intrinsics. Right now it will just return then original ID which is probably not expected
Nevermind, I can't read. It will return not_intrinsic although I still think this is a possible source of error


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69562/new/

https://reviews.llvm.org/D69562





More information about the llvm-commits mailing list