[PATCH] D69562: Mapping of FP operations to constrained intrinsics

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: llvm/lib/IR/FloatingPoint.cpp:81
 
+Intrinsic::ID getConstrainedIntrinsic(const Instruction &Instr) {
+  Intrinsic::ID IID = Intrinsic::not_intrinsic;
----------------
kpn wrote:
> For something that's not part of a class, shouldn't it have a more specific name? Maybe getConstrainedIntrinsicID()?
Eh, scratch half of that comment, but I do still prefer the more specific name "getConstrainedIntrinsicID".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69562/new/

https://reviews.llvm.org/D69562