[PATCH] D69849: [mips] Implement Octeon+ `saa` and `saad` instructions

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 07:59:28 PST 2019


Petar.Avramovic accepted this revision.
Petar.Avramovic added a comment.
This revision is now accepted and ready to land.

Correction from previous comment, tests for SaaAddr and SaadAddr are already present.

Remaining question is about flags for tests, 
for gnu-as both `-mips32` and `-mips64` are not compatible with  `-march=octeon+`, minimum requirement is `-mips64r2`, but feature compatibility could be addressed in another patch.

LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69849/new/

https://reviews.llvm.org/D69849





More information about the llvm-commits mailing list