[PATCH] D69562: Mapping of FP operations to constrained intrinsics

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff marked an inline comment as done.
sepavloff added a comment.

In D69562#1732337 <https://reviews.llvm.org/D69562#1732337>, @kpn wrote:

> The IRBuilder handles mapping non-constrained operations to constrained operations already. So a front-end just needs to enable strict mode in the IRBuilder and most everything "just works". And clang uses the IRBuilder, so we're good there. Are you working on a front-end that doesn't use the IRBuilder?


In the inliner (D69798 <https://reviews.llvm.org/D69798>) we need to know if we need to use constrained intrinsic prior to the instruction creation. Besides, instruction there are created without operands. So IRBuilder is not suitable in this case.



================
Comment at: llvm/lib/IR/FloatingPoint.cpp:170
+        IID = Intrinsic::experimental_constrained_trunc;
+        break;
+      default:
----------------
kpn wrote:
> Can you please update docs/AddingConstrainedIntrics.rst as well? When new intrinsics are added this switch here would need to be updated as well. Might as well document that fact.
Depending on whether D69887 will be accepted or not, the wording would be different. I will update the doc when things become definite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69562/new/

https://reviews.llvm.org/D69562