[PATCH] D69839: [DebugInfo] Fix for stopping emission of debug_macinfo section in normal case and -fno-debug-macro switch enabled case.

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 11:43:31 PST 2019


SouraVX added a comment.

Hi, Sorry, I just missed out the key part. This patch fixes / stop emission of ...
When "-fno-debug-macro' switch is enabled, which is by default. 
So all CUNode->getMacro() should be empty in first place, since no debug information of macro is cooked by clang ?? Right?
So for this case @dblaikie your concerns seems reasonable, but this patch, doesn't touches those things. I may be wrong here ??


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69839/new/

https://reviews.llvm.org/D69839





More information about the llvm-commits mailing list