[PATCH] D69552: Move floating point related entities to namespace level

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 01:10:03 PST 2019


simoll added a comment.

Thanks for the patch!
Factoring the constrained fp enums out of the ConstrainedFPIntrinsic is also something we need to the vector predication extension (https://reviews.llvm.org/D57504).
One nitpick, the name `FloatingPoint.h` seems very unspecific. How about going for something like `FPEnv.h`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69552/new/

https://reviews.llvm.org/D69552





More information about the llvm-commits mailing list