[PATCH] D69633: [XCOFF][AIX] Differentiate usage of label symbol and csect symbol

Tue Nov 5 15:15:05 PST 2019

jasonliu marked an inline comment as done.
jasonliu added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1768
   // Handle common symbols.
   if (GVKind.isCommon() || GVKind.isBSSLocal()) {
     unsigned Align =
----------------
DiggerLin wrote:
> what about GVKind.isBSSExtern() ? 
> I think we need to deal with as .comm output
I don't think it's in the scope of this patch.
This patch is aiming for existing infrastructure.

If we know when we generate that GVKind, we should handle it in a separate patch. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69633/new/

https://reviews.llvm.org/D69633