[PATCH] D69824: Extends the tblgen macro to allow mlir-tblgen to be installed

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 13:43:05 PST 2019


schweitz updated this revision to Diff 227959.
schweitz added a comment.

Thanks for catching the brain cramp.

I don't know about altering the macro generally.  I agree that having these package names hard coded here could be improved.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69824/new/

https://reviews.llvm.org/D69824

Files:
  llvm/cmake/modules/TableGen.cmake


Index: llvm/cmake/modules/TableGen.cmake
===================================================================
--- llvm/cmake/modules/TableGen.cmake
+++ llvm/cmake/modules/TableGen.cmake
@@ -160,7 +160,7 @@
     endif()
   endif()
 
-  if (${project} STREQUAL LLVM AND NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLVM_BUILD_UTILS)
+  if ((${project} STREQUAL LLVM OR ${project} STREQUAL MLIR) AND NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLVM_BUILD_UTILS)
     set(export_to_llvmexports)
     if(${target} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
         NOT LLVM_DISTRIBUTION_COMPONENTS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69824.227959.patch
Type: text/x-patch
Size: 574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191105/c8ace5a1/attachment.bin>


More information about the llvm-commits mailing list