[PATCH] D68070: [Clang][OpenMP Offload] Create start/end symbols for the offloading entry table with a help of a linker

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 13:34:02 PST 2019


Hahnfeld added a comment.

Heads up that this change broke compatibility with old binaries. Not sure if that is something worth to fix, but it should probably at least be spelt out somewhere...



================
Comment at: openmp/trunk/libomptarget/plugins/generic-elf-64bit/src/rtl.cpp:53
 #define NUMBER_OF_DEVICES 4
-#define OFFLOADSECTIONNAME ".omp_offloading.entries"
+#define OFFLOADSECTIONNAME "omp_offloading_entries"
 
----------------
This is an incompatible change, making it impossible to load old binaries because their section name doesn't match :-(


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68070/new/

https://reviews.llvm.org/D68070





More information about the llvm-commits mailing list