[PATCH] D69817: Fix OrcError build with modules enabled.

[Volodymyr Sapsai via Phabricator via llvm-commits]

vsapsai added a comment.

In D69817#1734427 <https://reviews.llvm.org/D69817#1734427>, @beanz wrote:

> Adding `exclude header "ExecutionEngine/Orc/OrcError.h"` to the module specification for `LLVM_ExecutionEngine` seems like a more appropriate fix.


That's not enough. RPCError.cpp includes "llvm/ExecutionEngine/Orc/RPC/RPCUtils.h" which is a part of LLVM_ExecutionEngine module and we still have unsatisfied dependency LLVM_ExecutionEngine -> LLVM_intrinsic_gen. I agree it is better to have a proper OrcError module but at the moment I don't see a clear set of headers constituting such a module. We can add together error and RPC headers but to me this combination looks weird. Though I haven't worked with JIT/Orc/RPC code and maybe that's the most natural composition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69817/new/

https://reviews.llvm.org/D69817